Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new beds behavior since 12.20.9260 #235

Closed
wants to merge 10 commits into from
Closed

feat: new beds behavior since 12.20.9260 #235

wants to merge 10 commits into from

Conversation

omeranha
Copy link
Contributor

@omeranha omeranha commented Feb 26, 2022

Description

missing:

Type of change

  • New feature (non-breaking change(I think) which adds functionality)

missing:
remove all beds from .otbm.
rework beds in items.xml.
maybe change how npcs sell bed kits.
add beds="count" in houses.xml.
maybe more verifications in canUse bed.cpp.
add beds in store (probably need store in xml pr, 1 offer of bed will give the player 2 items).
@omeranha omeranha changed the title New beds [Feature/Enhancement] - New beds behavior since 12.20.9260 Feb 28, 2022
@sonarqubecloud

This comment was marked as outdated.

@Costallat Costallat force-pushed the main branch 5 times, most recently from 36d0101 to 76fd4f6 Compare April 12, 2022 19:05
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the Stale No activity label May 13, 2022
@sonarqubecloud

This comment was marked as outdated.

@Luccoo
Copy link

Luccoo commented Sep 23, 2022

PR muito bom parabéns ao autor funcionou 100% só em items.xml fiz diferente

<!-- blue Bed -->











<item id="32518" article="a" name="blue headboard"> <!-- Male Dormindo virado pro sul-->
	<attribute key="type" value="bed"/>
	<attribute key="partnerdirection" value="south"/>
	<attribute key="maletransformto" value="32473"/> <!-- Quando acordar Virar cabeceira vazia -->
</item>

<item id="32509" article="a" name="blue headboard"> <!-- Female Dormindo virado pro sul-->
	<attribute key="type" value="bed"/>
	<attribute key="partnerdirection" value="south"/>
	<attribute key="femaletransformto" value="32473"/> <!-- quando acordar Virar cabeceira vazia -->
</item>

<item article="a" id="32482" name="blue footboard"> <!-- colchão virado pro north -->
	<attribute key="weight" value="3000" />
	<attribute key="rotateTo" value="32500"/> <!-- Colchão Virado pro west -->
	<attribute key="type" value="bed"/>
		<attribute key="bedpart" value="blanket"/>
		<attribute key="bedpartof" value="32473"/>
	<attribute key="wrapableTo" value="23473" /> <!-- Parcel Wrap -->
	<attribute key="partnerDirection" value="north"/>
	<attribute key="femaletransformto" value="32527"/> <!-- corpo Female Dormindo virado pro north -->
	<attribute key="maletransformto" value="32527"/> <!-- Corpo male dormindo virado pro north -->
</item> 

<item id="32527" article="a" name="blue footboard"> <!-- Corpo female/male dormindo virado pro north -->
	<attribute key="type" value="bed"/>
	<attribute key="partnerdirection" value="north"/>
	<attribute key="femaletransformto" value="32482"/> <!-- female Voltar a ser colchão virado pro norte -->
	<attribute key="maletransformto" value="32482"/> <!-- male Voltar a ser colchão virado pro norte -->
</item>
<item article="a" id="32491" name="blue headboard"> <!-- Cabeceira vazia virada para east -->
	<attribute key="weight" value="3000" />
	<attribute key="rotateTo" value="32473"/> <!-- Cabeceira para sul -->
	<attribute key="type" value="bed"/>
		<attribute key="bedpart" value="pillow"/>
		<attribute key="bedpartof" value="32500"/>		
	<attribute key="wrapableTo" value="23473"/> <!-- Caixa wrap -->
	<attribute key="partnerDirection" value="east"/>
	<attribute key="femaletransformto" value="32536"/> <!-- female dormindo pro east -->
	<attribute key="maletransformto" value="2497"/> <!-- male dormindo pro east -->
</item>

<item id="32536" article="a" name="blue headboard"> <!-- Female dormindo pro east -->
	<attribute key="type" value="bed"/>
	<attribute key="partnerdirection" value="east"/>
	<attribute key="femaletransformto" value="32491"/> <!-- Female voltar a ser cabeceira vazia -->
</item>
	
<item id="2497" article="a" name="blue headboard"> <!-- male dormindo pro east -->
	<attribute key="type" value="bed"/>
	<attribute key="partnerdirection" value="east"/> 
	<attribute key="maletransformto" value="32491"/> <!-- male voltar a ser cabeceira vazia -->
</item>

<item article="a" id="32500" name="blue footboard"> <!-- Colchão vazio para west -->
	<attribute key="weight" value="3000" />
	<attribute key="rotateTo" value="32482"/> <!-- Colhão para o north -->
	<attribute key="type" value="bed"/>
		<attribute key="bedpart" value="blanket"/>
		<attribute key="bedpartof" value="2498"/>		
	<attribute key="wrapableTo" value="23473" /> <!-- Caixa wrap -->
	<attribute key="partnerDirection" value="west"/>
	<attribute key="femaletransformto" value="2498"/> <!-- Corpo Female/male dormindo para west -->
	<attribute key="maletransformto" value="2498"/> <!-- Corpo Female/male dormindo para west -->
</item> 

<item id="2498" article="a" name="blue footboard"> <!-- Corpo Female/male dormindo para west -->
	<attribute key="type" value="bed"/>
	<attribute key="partnerdirection" value="west"/>
	<attribute key="femaletransformto" value="32500"/> <!-- Female voltar acolchão vazio para west -->
	<attribute key="maletransformto" value="32500"/> <!-- Female voltar acolchão vazio para west -->
</item>

@Luccoo

This comment was marked as resolved.

@github-actions github-actions bot removed the Stale No activity label Sep 24, 2022
@Luccoo

This comment was marked as resolved.

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the Stale No activity label Oct 25, 2022
@github-actions github-actions bot removed the Stale No activity label Dec 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Feb 18, 2023
@dudantas dudantas changed the title [Feature/Enhancement] - New beds behavior since 12.20.9260 feat: new beds behavior since 12.20.9260 May 21, 2023
@icavalheiro

This comment was marked as spam.

@github-actions github-actions bot removed the Stale No activity label Jul 21, 2023
@luan luan mentioned this pull request Jul 22, 2023
1 task
@omeranha omeranha closed this Jul 24, 2023
dudantas pushed a commit that referenced this pull request Jul 28, 2023
This is #235 re-done on top of main. Added all beds to store/npc appropriately and pulled number of beds info from Tibia.com (via tibiadata api)
@luan luan deleted the new-beds branch August 27, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: PRs Done
Development

Successfully merging this pull request may close these issues.

4 participants